[DC] Use href and target instead of onClick for opening URLs #7923
+7
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoonaoh
added a commit
that referenced
this pull request
Dec 2, 2024
Co-authored-by: Yoona Oh <[email protected]>
yoonaoh
added a commit
that referenced
this pull request
Dec 2, 2024
…7924) Co-authored-by: Yoona Oh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FixesAB#30348749
For External Git, repo can be any value, including pseudoURLs, which can lead to XSS attacks. Using href on the Link component instead of onClick={window.open()}, will catch any unsafe URLs